This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix for NPE during TermsAggregation instantiation #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How would those fields not be present? They are not optional or modifiable and always returned by ES as far as I can see. |
|
We currently use ES 1.3.4, which returns TermsAggregations result without both of those fields. It could be a bug for that old version. |
|
Fair enough. Instead of null check using |
|
Sure. I'll update this PR tomorrow |
VlasShatokhin
force-pushed
the
terms_npe_fix
branch
from
7ee35e9 to
20250db
Compare
VlasShatokhin
force-pushed
the
terms_npe_fix
branch
from
20250db to
88387d1
Compare
|
I didn't found any other usages of SUM_OTHER_DOC_COUNT and DOC_COUNT_ERROR_UPPER_BOUND fields, so looks we won't have such issue with other aggregation classes. |
kramer
pushed a commit
that referenced
this pull request
Jun 23, 2015
bugfix: NPE in TermsAggregation instantiation with older ES server versions
|
Thanks for your contribution @VlasShatokhin! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could get NPE during TermsAggregation instantiation since following fields may not be presented in aggregation response: