Move ABI versioning information from Parser to TreeSitter
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it _should_ not be triggered normally, I do think that it should mirror the behaviour of the setter error behaviour.
Since we have re-introduced `TreeSitter` as a metaclass, I felt that the ABI versioning information feels more at place there than it does in the `Parser`. Conveniently, the generation of this versioning file takes place right before compilation and the header files can thus be generated properly on `package`. Subsequent commits will focus on laying the foundation for sunsetting the corresponding `Parser` methods.
This affects: - `Parser#getLanguageVersion` - `Parser#getMinimumCompatibleLanguageVersion` Both methods have been marked as deprecated for removal, each JavaDoc explaining the alternative method to use. The native implementations of the methods have been replaced with a delegating call to the new methods of `TreeSitter`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already have a class dedicated to
tree-sitterversioning information, we should use it. Although ABI information was introduced back in1.6.0, there were no dedicated versioning classes to contain this information, so we opted to store it in theParser. Now that we haveTreeSitter, said information feels more at place there, and as such we have opted to deprecate the following methods fromParser:Parser#getLanguageVersionParser#getMinimumCompatibleLanguageVersionAnd replace them with the equivalent
TreeSittermethods:TreeSitter#getCurrentABIVersionTreeSitter#getMinimumABIVersionAs such the native code from
Parserwas moved toTreeSitter. Those deprecated methods are marked for removal, but they currently just call the new methods.