Language enum values now provide all field names
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the name suggest, it allows us to retrieve the field name by ID. It currently sees no use in the code, but I have plans to use it in the constructor to eagerly fetch all the valid field names of a language.
This should not have any impact on the API, as we use a more restrictive type now as opposed to before.
However, the API does still retain the `Language#getTotalFields` method. This ensures that there are no breaking changes with the field change.
Really does not make any more sense to keep holding on to these methods. Both were introduced in order to mitigate the possibility of breaking changes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to just providing the
totalFieldscount, we instead now provide a complete collection of field names in the aptly namedfieldsinstance variable. This PR also introduces the following changes:CollectiontoListfor allLanguagecontainer member;Language#getTotalSymbolsLanguage#getTotalFields