Remove prettify to avoid circular bug #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavoguichard
force-pushed
the
remove-prettify-to-avoid-circular-bug
branch
from
800d483 to
6f210bc
Compare
|
After investigating a little longer I was able to generate a cleaner version of the In that file we can see the problem. After making this small change the generated |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported on #81 , the
Prettifytype is supposed to help with readability of resulting type ofMergeObjbut it has a - now - known bug that can cause infinitely recursive types thus killing TSC.You can read more about it here: remix-run/remix#6736