Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Reset label styling to fix leaking #1886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reset label styling to fix leaking #1886

wants to merge 1 commit into from

Conversation

EldRoos
Copy link
Contributor

@EldRoos EldRoos commented Dec 18, 2024

Closes: #711

@green-design-system-bot
Copy link
Contributor

🦋 Changeset status

None or empty changeset found. This PR will not result any new releases.

If you believe this is incorrect, please add a changeset by running npx changeset, and then commiting the resulting changeset file.

You can also explicitly add an empty changeset by running:
npx changeset add --empty

@green-design-system-bot
Copy link
Contributor

👋 Thanks for creating a pull request!

🚀 Checkout the storybooks we've created for it:

splashdust
splashdust reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@splashdust splashdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is potentially breaking, since it adds a element selector. Let's hold off on this one until the next major release, which should be fairly soon.

@splashdust splashdust added the Status: Potentially breaking This PR contains a potentially breaking change, and should be held until next major release label Jan 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@splashdust splashdust splashdust left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Potentially breaking This PR contains a potentially breaking change, and should be held until next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label: Have too much bottom margin on IBP
2 participants
@EldRoos @splashdust