-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Declarative Layout refine and refactor #1966
Draft
splashdust
wants to merge
15
commits into
main
Choose a base branch
from
feat/decl-layout-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset statusNone or empty changeset found. This PR will not result any new releases. If you believe this is incorrect, please add a changeset by running You can also explicitly add an empty changeset by running: |
👋 Thanks for creating a pull request! 🚀 Checkout the storybooks we've created for it: |
And give them their own section in the API table
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it
Since we've been trying out and using this system for a while now, some patterns and opportunities for improvement have started to emerge. This PR is a step towards finalizing the declarative layout system.
The focus of this PR is to streamline the available properties for building layouts using GDS tokens. That means that rarely used and non-layout related properties are being removed. Also ome support for custom values are being removed, except for sizing and positioning. Declarative Layout is not meant to replace CSS, just to reduce or eliminate the need for layout CSS.
So far in this PR
Refactor
transparent
andcurrentColor
. This simplifies implementation and makes color properties more consistent.tokenName/transparency
, where transparency is optional.box-sizing
toborder-box
by defaultborder-color
toprimary
by defaultborder
property now works like css shorthand border property, ie.size style color
border-style
property added for completenessborder
,border-width
,border-color
,border-style
, andborder-radius
, all with the same parameter structure as css.@styleExpressionProperty
logic moved to reusable functions.gds-grid
:auto-columns
now support any CSS units. If no unit is specified, it still appendspx
for backwards compatibility.Removed
These properties have been removed. Any edge-cases that need these will have to be written in regular CSS
pointer-events
user-select
cursor
transform-style
Other improvements