Textarea: Resize improvements, handle, paste etc #1968
Conversation
🦋 Changeset statusBased on the included changeset, the following releases will be published as a result of this PR:
Note: If unpublished changesets where merged to |
There was a problem hiding this comment.
Two things come to mind:
- On the
resizableproperty, themanualoption should allow the user to resize by handle only. So in that mode there should be no automatic resize based on content, only manual resize by the user. In the other modes, no resize handle should be present at all. Currently it looks like theresizableproperty is not used at all? It's not being read anywhere in the code. - See if you can set the CSS
resizeproperty on the#fieldelement instead. It may require some minor changes to field-base, but then we would get the handle always in the corner. But skip if it turns out to be a rabbit hole :)
…green into textarea/patch-resizing
| connectedCallback(): void { | ||
| super.connectedCallback() | ||
| TransitionalStyles.instance.apply(this, 'gds-field-base') | ||
| } |
There was a problem hiding this comment.
This still needs to be here for Transitional styles to work
There was a problem hiding this comment.
Will add it back, not sure why I removed it on the first place!
| if ( | ||
| element.value === '' || | ||
| this.resizable === 'false' || | ||
| this.resizable === 'manual' | ||
| ) { | ||
| // If the textarea is empty, reset to the default number of rows | ||
| this.rows = this._defaultRows | ||
| // Clear any manual resize height | ||
| element.style.height = '' | ||
| } else { |
There was a problem hiding this comment.
Maybe this bit can be removed entirely now?
In particular, the behavior when you paste in a manual field is a bit unexpected:
- Make the field larger using the resize handle
- Paste a large chunk of text
- You would expect the field to stay the same size, but instead it shrinks to initial size
The missaligment was because of a wrong if statement
|
This PR fixes the following: