Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Package the python module #1

Merged
merged 21 commits into from
Apr 25, 2023
Merged

Package the python module #1

merged 21 commits into from
Apr 25, 2023

Conversation

pcschreiber1
Copy link
Collaborator

@pcschreiber1 pcschreiber1 commented Jan 13, 2023 •
edited
Loading

Das Python Modul in ein Packet verpacken, pip installierbar machen und auf PyPIP zur Verfügung stellen

Must-have

  • Packet dependencies und CI dependencies trennen
    • pyproject.toml fasst die dependencies
    • CI dependencies werden über pip-compile gepflegt
  • Lokal pip installierbar
    • Kombination aus pyproject.toml und setup.py
  • Auf PyPIP bereitgestellt
  • Lizenz

Nice-to-have

  • Package Informationen im pyproject.toml pflegen
  • Bereitstellung von Beispieldateien im Packet

Philipp Schreiber added 3 commits January 12, 2023 16:33
Updated gitignore.
1e36b66
Created new pin for dependencies using pip-compile.
9f3efa2
Rename example folder so it is automatically excluded from package.
e316104 
Otherwise object is too large for PyPI storage.
If examples are to be incuded, create examples folder inside the package.
@pcschreiber1 pcschreiber1 marked this pull request as draft January 13, 2023 17:18
Philipp Schreiber added 3 commits January 16, 2023 09:03
Added additional metadata.
443af10
Added metadata and updated requirements.txt.
07ab8a9 
Needed to limit pip-tools version due to `click` conflict with spacy.
Excluded direct dependencies.
b21aa11 
User now new to install the spaCy models themselves.
Note, a warning is raised if Default model is not downloaded.
@pcschreiber1
Copy link
Collaborator Author

pcschreiber1 commented Jan 16, 2023 •
edited
Loading

Direct dependencies (z.B. de-core-news-sm @ https://github.com/explosion/spacy-models/releases/download/de_core_news_sm-3.0.0/de_core_news_sm-3.0.0-py3-none-any.whl) sind nicht möglich in PyPI (siehe PyPI Issue 9404).

Daher werden Nutzer:innen diese, wie in spaCy, selbst herunterladen müssen.

@pcschreiber1 pcschreiber1 marked this pull request as ready for review March 29, 2023 09:26
@pcschreiber1 pcschreiber1 merged commit ec1b9b7 into master Apr 25, 2023
@pcschreiber1 pcschreiber1 deleted the feature/package_build branch April 25, 2023 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sebastian-sohr sebastian-sohr Awaiting requested review from sebastian-sohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pcschreiber1