fixed issue that happens when modifying only lines not covered by code-coverage #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bionda740
changed the title
|
@sebastianbergmann can you review this please? |
sebastianbergmann
force-pushed
the
main
branch
from
355c0ab to
7b5f250
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue when modifying only the value of a constant in our source.
Since the modified line of code was not covered by code-coverage, and it was the only modified line, phpcov returned the following error:
'Unable to detect executable lines that were changed. Are you sure your --path-prefix is correct?'
I would propose to solve the problem by also counting the uncovered lines, and return the error only if there is actually no modified line, both covered and uncovered.