PHPunit not expect generic exception?

[yangzizhe]

InvalidArgumentException: You must not expect the generic exception class，
when I test

class MyTest extends PHPUnit_Framework_TestCase
{
/**
* @ExpectedException Exception
* @expectedExceptionMessage Some Message
*/
public function testExceptionHasRightMessage()
{
throw new Exception('Some Message', 20);
}
}

with PHPUnit3.6.7
why ?

IF PHPunit not expect generic exception , why the document has this example?

[sebastianbergmann]

Fixed in the documentation.

[digitalprecision]

For the record, this is a fairly critical issue as we are unable to throw generic exceptions, and personally I don't feel like creating custom exceptions just to pass unit testing. Is there any way you could remove this restriction?

[sebastianbergmann]

The restriction has been removed for PHPUnit 3.7.

[digitalprecision]

Thanks for responding. When will 3.7 be available? Stable?

[HelloGrayson]

Any way this can get brought into 3.6?

[digitalprecision]

I came up with a work around until 3.7 is stable. http://melikedev.com/2012/08/24/phpunit-you-must-not-expect-the-generic-exception-class/

[HelloGrayson]

@digitalprecision that's good but less ideal - cc @sebastianbergmann - do you advise upgrade to 3.7?

[sebastianbergmann]

Feel free to test PHPUnit 3.7.0RC1; that is what release candidates are for.

[iNamik]

Inspired by @digitalprecision I designed a robust solution that is easier to bolt onto your test cases:

https://gist.github.com/4298350

The gist includes 3 ways to incorporate generic exception handling into your test cases:

• Via trait if your PHP version supports it
• Via extending a new base TestCase class
• Via global functions

The gist code includes all three versions, but you can delete the versions you don't want (or can't compile) from your copy of the code.

There is also a full test suite available to test the functionality.

[joaoinacio]

Much simpler to patch phpunit, something like so:
/usr/share/php/PHPUnit/Framework/TestCase.php:

-    if ($exceptionName == 'Exception' || $exceptionName == '\\Exception') {
-        throw new InvalidArgumentException(
-            'You must not expect the generic exception class.'
-        );
-    }

Is there a commit from 3.7 that could possibly apply to 3.6?

[digitalprecision]

@joaoinacio: Patching wasn't an option for us as we have multiple UT servers and we didn't want to be responsible for maintaining vendor code. The author was asked if he would backport to 3.6 but never responded directly to the question, rather he suggested we beta test 3.7. You can use mine or @iNamik suggested work arounds.

[srcspider]

For anyone using travis with 5.2 due to dependencies to other systems that refuse to drop 5.2 you can use this pattern to bypass the phpunit limitation, it's also slightly better.

try {
    $proc->errors(); // if this doesn't throw an exception, the next line will fail the test
    throw new Exception('Failed asserting blah blah blah exception.');
}
catch (Exception $e) {
    // ensure we got the right exception
    $this->assertEquals('Place here the expected Exception message.', $e->getMessage());
}

[jtsternberg]

@srcspider sorry, where would I use that? In the test itself? and if so, what is the $proc variable in your example?