coverage-text: do not use colors if --colors=never #1907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -490,6 +490,9 @@ class_exists($arguments['printer'], false)) { | |||
| if ($arguments['coverageText'] == 'php://stdout') { | |||
| $outputStream = $this->printer; | |||
| $colors = $arguments['colors']; | |||
| if($colors == PHPUnit_TextUI_ResultPrinter::COLOR_NEVER) { | |||
There was a problem hiding this comment.
why not just $colors = $arguments['colors'] && $arguments['colors'] != PHPUnit_TextUI_ResultPrinter::COLOR_NEVER?
There was a problem hiding this comment.
just thinking about avoiding a double assignment - maybe your way is more readable though :)
There was a problem hiding this comment.
yeah, just thought about the same thing... will change it
there is no coverage driver for PHP 7 on travis right now, so just skip it. it can be enabled as soon as xdebug supports code coverage on PHP 7
|
👍 |
|
Merged manually, thanks. |
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use colors when using
--coverage-textalong with--colors=never.See #1771 and #1892
(replaces #1906)