Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up the Test Double generator and runtime #5697

Closed
wants to merge 38 commits into from

Conversation

sebastianbergmann
Copy link
Owner

This closes #5246, #5247, #5248, #5249, #5250, #5310, #5311, #5312, #5313, #5314, #5316, #5321, #5416, #5424, and #5536 as well as deletes now unused code and simplifies existing code.

@sebastianbergmann sebastianbergmann added the feature/test-doubles Test Stubs and Mock Objects label Feb 8, 2024
@sebastianbergmann sebastianbergmann added this to the PHPUnit 12.0 milestone Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 95.62044% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.50%. Comparing base (0e87363) to head (753eda6).
Report is 205 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
src/Framework/MockObject/Generator/MockBuilder.php 90.38% 5 Missing ⚠️
src/Framework/MockObject/Generator/Generator.php 97.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5697      +/-   ##
============================================
- Coverage     94.66%   94.50%   -0.16%     
+ Complexity     6733     6613     -120     
============================================
  Files           712      700      -12     
  Lines         20305    19778     -527     
============================================
- Hits          19221    18692     -529     
- Misses         1084     1086       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann force-pushed the phpunit-12/test-double-cleanup branch 3 times, most recently from bdd79c1 to 6f86088 Compare February 19, 2024 07:52
@sebastianbergmann sebastianbergmann force-pushed the phpunit-12/test-double-cleanup branch 4 times, most recently from ade5999 to 7f8d20e Compare March 2, 2024 11:26
@sebastianbergmann sebastianbergmann force-pushed the phpunit-12/test-double-cleanup branch from 3425297 to db6b3ab Compare September 5, 2024 06:44
@sebastianbergmann sebastianbergmann removed this from the PHPUnit 12.0 milestone Oct 6, 2024
@sebastianbergmann sebastianbergmann deleted the phpunit-12/test-double-cleanup branch October 7, 2024 13:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature/test-doubles Test Stubs and Mock Objects type/backward-compatibility Something will be/is intentionally broken type/refactoring A refactoring that should be applied to make the code easier to understand and maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TestCase::createTestProxy()
1 participant