Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent duplicate call of NamePrettifier::prettifyTestMethodName() #5727

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 9, 2024

stumbled over it in a recent blackfire profile

grafik

@staabm staabm marked this pull request as ready for review March 9, 2024 16:45
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (0f715c1) to head (a06a85d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5727   +/-   ##
=========================================
  Coverage     90.01%   90.01%           
  Complexity     6497     6497           
=========================================
  Files           688      688           
  Lines         19718    19719    +1     
=========================================
+ Hits          17749    17750    +1     
  Misses         1969     1969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory) labels Mar 9, 2024
@sebastianbergmann
Copy link
Owner

Cherry-picked into 10.5 and merged to 11.0 and main from there. Thanks!

@staabm staabm deleted the patch-1 branch March 9, 2024 17:39
@sebastianbergmann sebastianbergmann changed the title Prevent duplicate prettify in TestDoxBuilder Prevent duplicate call of NamePrettifier::prettifyTestMethodName() Mar 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants