-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Priority for hook methods #5890
Merged
sebastianbergmann
merged 1 commit into
sebastianbergmann:main
from
nikophil:feat/priority-in-hooks
Jul 26, 2024
Merged
Priority for hook methods #5890
sebastianbergmann
merged 1 commit into
sebastianbergmann:main
from
nikophil:feat/priority-in-hooks
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Jul 3, 2024
nikophil
force-pushed
the
feat/priority-in-hooks
branch
from
July 3, 2024 16:56
f144068
to
1d79984
Compare
sebastianbergmann
added
type/enhancement
A new idea that should be implemented
feature/test-runner
CLI test runner
labels
Jul 4, 2024
nikophil
force-pushed
the
feat/priority-in-hooks
branch
from
July 9, 2024 15:42
1d79984
to
597625a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
============================================
+ Coverage 94.17% 94.20% +0.02%
- Complexity 6597 6632 +35
============================================
Files 700 708 +8
Lines 19883 19980 +97
============================================
+ Hits 18725 18822 +97
Misses 1158 1158 ☔ View full report in Codecov by Sentry. |
nikophil
force-pushed
the
feat/priority-in-hooks
branch
3 times, most recently
from
July 10, 2024 08:20
f67762a
to
5dacc85
Compare
nikophil
force-pushed
the
feat/priority-in-hooks
branch
from
July 10, 2024 08:23
5dacc85
to
c797729
Compare
nikophil
commented
Jul 10, 2024
sebastianbergmann
force-pushed
the
feat/priority-in-hooks
branch
from
July 10, 2024 11:30
c797729
to
953a586
Compare
sebastianbergmann
changed the title
feat: introduce priority for hook methods
Priority for hook methods
Jul 16, 2024
sebastianbergmann
force-pushed
the
feat/priority-in-hooks
branch
from
July 16, 2024 08:15
953a586
to
aeec26c
Compare
nikophil
force-pushed
the
feat/priority-in-hooks
branch
3 times, most recently
from
July 18, 2024 06:46
1576526
to
77de942
Compare
sebastianbergmann
force-pushed
the
feat/priority-in-hooks
branch
from
July 18, 2024 07:27
77de942
to
39eeb31
Compare
nikophil
force-pushed
the
feat/priority-in-hooks
branch
from
July 18, 2024 08:13
39eeb31
to
1dfbde3
Compare
sebastianbergmann
force-pushed
the
feat/priority-in-hooks
branch
from
July 23, 2024 06:44
1dfbde3
to
1b94f00
Compare
sebastianbergmann
force-pushed
the
feat/priority-in-hooks
branch
from
July 26, 2024 07:48
1b94f00
to
cebecfb
Compare
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5889
I've introduced two new classes:
PHPUnit\Metadata\Api\HookMethod
: which is a value object with method's name and its priorityPHPUnit\Metadata\Api\HookMethodsCollection
which holds a collection ofHookMethod
s, and will return methods as string with the right priority when iterating on itHookMethods::hookMethods()
will now return an array ofHookCollections
, and the handling of the priority will be delegated to this class.BTW, I'm not really sure that
PHPUnit\Metadata\Api\
is the right namespace for those classes.