Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BLE: Add Enhanced_Connection_Complete HCI event #4576

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sacca97
Copy link

@sacca97 sacca97 commented Oct 30, 2024

Related to #2581.
Should be no big deal. I did not add tests for it but I'm actively using it.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (a9eed2d) to head (ad39ce8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4576      +/-   ##
==========================================
- Coverage   81.58%   78.71%   -2.88%     
==========================================
  Files         340      333       -7     
  Lines       85351    80427    -4924     
==========================================
- Hits        69631    63305    -6326     
- Misses      15720    17122    +1402     
Files with missing lines Coverage Δ
scapy/layers/bluetooth.py 90.05% <100.00%> (+0.03%) ⬆️

... and 75 files with indirect coverage changes

@guedou
Copy link
Member

guedou commented Jan 1, 2025

Thanks for the PR. Could you add a dissection unit test? We will ensure that the binding works correctly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants