-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
文档 [What is SPU?]翻译成中文文档 #1043
文档 [What is SPU?]翻译成中文文档 #1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @2429887991, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request translates the English documentation for "What is SPU?" into Chinese. The changes involve updating the getting_started.po
file within the docs/locales/zh_CN/LC_MESSAGES/
directory to provide a Chinese translation of the introductory text about SPU (Secure Processing Unit). The translated text explains the purpose and functionality of SPU, including its role as a compiler and runtime suite for secure computation, its support for XLA IR from various frameworks, and its extensible architecture for MPC protocols.
Highlights
- Translation: The documentation for 'What is SPU?' has been translated into Chinese.
- SPU Explanation: The translated documentation provides a Chinese explanation of SPU's purpose, functionality, and architecture.
Changelog
- docs/locales/zh_CN/LC_MESSAGES/getting_started.po
- Translated 'What is SPU?' to 'SPU 是什么?'
- Translated the description of SPU as a secure processing unit.
- Translated the explanation of SPU's compiler, XLA support, and MPC language.
- Translated the section on SPU's runtime and its support for multiple MPC protocols.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
From English to Chinese script,
SPU's secrets, now equipped.
A language bridge, a clearer view,
For developers, old and new.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request translates documentation into Chinese. The changes look straightforward and improve accessibility for Chinese-speaking users. However, some minor improvements could be made to ensure clarity and accuracy.
Summary of Findings
- Inconsistent use of spacing around Chinese characters: There are inconsistencies in the use of spacing around Chinese characters and English letters/numbers. While not strictly incorrect, adding consistent spacing improves readability.
- Potential for improved accuracy in translation: While the translations are generally good, some phrases could be refined to better reflect the original meaning and be more idiomatic in Chinese.
Merge Readiness
The pull request is almost ready for merging. Addressing the spacing inconsistencies and considering the suggested improvements to translation accuracy would further enhance the quality of the documentation. I am unable to directly approve this pull request, and recommend that another reviewer does so after these changes are made.
@@ -377,7 +377,7 @@ msgid "" | |||
"by SPU runtime. Currently, SPU team highly recommends using `JAX " | |||
"<https://github.com/google/jax>`_ and its sibling - `Flax " | |||
"<https://github.com/google/flax>`_." | |||
msgstr "" | |||
msgstr "SPU 编译器采用 XLA 作为其前端中间表示(IR)。因此,SPU 支持来自 TensorFlow、JAX 或 PyTorch 的 XLA IR 输出。在内部,SPU 编译器会将 XLA 编译成一种特定于多方计算 (MPC) 的 MLIR 语言。这种语言随后会由 SPU 运行时进行解释。目前,SPU 团队强烈建议使用 JAX 及其姊妹框架 Flax。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rephrasing "SPU 编译器采用 XLA 作为其前端中间表示(IR)。因此,SPU 支持来自 TensorFlow、JAX 或 PyTorch 的 XLA IR 输出。在内部,SPU 编译器会将 XLA 编译成一种特定于多方计算 (MPC) 的 MLIR 语言。这种语言随后会由 SPU 运行时进行解释。目前,SPU 团队强烈建议使用 JAX 及其姊妹框架 Flax。" to be more concise and natural in Chinese. For example, you could say "SPU 编译器采用 XLA 作为前端中间表示,因此支持 TensorFlow、JAX 和 PyTorch 的 XLA IR 输出。SPU 内部会将 XLA 编译为 MPC 专属的 MLIR,并由运行时解释执行。SPU 团队推荐使用 JAX 及其姊妹框架 Flax。"
msgstr "SPU 编译器采用 XLA 作为前端中间表示,因此支持 TensorFlow、JAX 和 PyTorch 的 XLA IR 输出。SPU 内部会将 XLA 编译为 MPC 专属的 MLIR,并由运行时解释执行。SPU 团队推荐使用 JAX 及其姊妹框架 Flax。"
@@ -387,7 +387,7 @@ msgid "" | |||
"extensible**, protocol developers can hack into MPC protocols with " | |||
"minimum effort and let the SPU compiler/runtime translate and interpret " | |||
"complicated frontend logic on it." | |||
msgstr "" | |||
msgstr "为了提供安全性证明,SPU 运行时(作为后端)实现了多种多方计算协议。而且,SPU 运行时的设计具有高度可扩展性,协议开发者能够便捷地定制开发多方计算协议,并让 SPU 编译器/运行时在其上翻译和解释复杂的前端逻辑。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rephrasing "为了提供安全性证明,SPU 运行时(作为后端)实现了多种多方计算协议。而且,SPU 运行时的设计具有高度可扩展性,协议开发者能够便捷地定制开发多方计算协议,并让 SPU 编译器/运行时在其上翻译和解释复杂的前端逻辑。" to be more concise and natural in Chinese. For example, you could say "SPU 运行时(后端)实现了多种多方计算协议以提供安全性证明。SPU 运行时设计高度可扩展,协议开发者能够便捷地定制开发多方计算协议,并使 SPU 编译器/运行时翻译和解释复杂的前端逻辑。"
msgstr "SPU 运行时(后端)实现了多种多方计算协议以提供安全性证明。SPU 运行时设计高度可扩展,协议开发者能够便捷地定制开发多方计算协议,并使 SPU 编译器/运行时翻译和解释复杂的前端逻辑。"
Pull Request
What problem does this PR solve?
Issue Number: Fixed #1014
Possible side effects?
Performance:
Backward compatibility: