Do Not Review: Remove Workflow Interface Tests workflow and related test folder #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noopur <noopur@intel.com>
noopurintel
requested review from
theakshaypant,
MasterSkepticista,
kta-intel,
psfoley,
payalcha,
rahulga1,
rajithkrishnegowda,
ishaileshpant,
tanwarsh,
teoparvanov,
aayushgaintel,
gbikkiintel,
pasokan-intel and
srikanthenugul
as code owners
|
Hi @noopurintel , could you update the PR description as per the template? |
noopurintel
changed the title
noopurintel
changed the title
There was a problem hiding this comment.
This means task runner and workflow API tests will be run for all PRs, right?
Using labels is one way to reduce the number of tests run per PR. Is it possible to run tests based on the directories where changes have been made, thus reducing the CI run time and not running unnecessary tests?
There was a problem hiding this comment.
While this PR does clean-up duplication of Workflow API test cases, there are two folders which now contain end-to-end test cases
tests/github, andtests/end_to_end
As per my understanding the old convention was
tests/github: End to End test casestests/openfl: Module level test cases
Request to please harmonize the test directory also to avoid any confusion
Signed-off-by: Noopur <noopur@intel.com>
Signed-off-by: Noopur <noopur@intel.com>
noopurintel
changed the title
Signed-off-by: Noopur <noopur@intel.com>
Signed-off-by: Noopur <noopur@intel.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
Workflow Functional E2E which is already a part of PR pipeline covers all the tests present in Workflow Interface Tests in Pytest framework, thus removing the workflow as well as folder
LocalRuntimespecific to it.Earlier, both of these were kept just to ensure smooth transition and stability of pytest based workflow.
Testing
PR pipeline already covers Functional E2E workflow.