Cleanup #1422
Open
Cleanup #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
MasterSkepticista
requested review from
theakshaypant,
kta-intel,
noopurintel,
psfoley,
payalcha,
rahulga1,
rajithkrishnegowda,
ishaileshpant,
tanwarsh and
teoparvanov
as code owners
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
rahulga1
approved these changes
Mar 5, 2025
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
|
@MasterSkepticista can you please keep the PR in WIP/Draft state when it is being updated, that will avoid confusion for ppl to review it pre-maturely. |
|
@rahulga1 Sure. Marked as WIP. I have kept it in this state for CI to trigger, hope this is ok. |
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
MasterSkepticista
force-pushed
the
karansh1/dce
branch
2 times, most recently
from
203e4d3 to
2372d1e
Compare
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
MasterSkepticista
force-pushed
the
karansh1/dce
branch
from
14bbe81 to
c878271
Compare
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
MasterSkepticista
force-pushed
the
karansh1/dce
branch
from
70ceaf1 to
6343019
Compare
MasterSkepticista
force-pushed
the
karansh1/dce
branch
from
6343019 to
9855164
Compare
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
MasterSkepticista
force-pushed
the
karansh1/dce
branch
2 times, most recently
from
e2338a4 to
50ebdef
Compare
|
Ready for review. P.S.: Thanks @noopurintel for digging this 50ebdef |
rahulga1
reviewed
Mar 5, 2025
psfoley
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Overall changes look good here, @MasterSkepticista! use_delta_updates parameter name will also need to be updated in OpenFL-Security once this is merged.
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
rahulga1
approved these changes
Mar 6, 2025
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
Signed-off-by: Shah, Karan <kbshah1998@outlook.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
TASK_REGISTRY)delta_updates->use_delta_updates, to make it consistent with aggregator that went through a similar change.self.logger.Prerequisite for a larger refactor. Did not want to burden refactor PRs with cleanups like these.