Fix foldstyle option #1804
Merged
Fix foldstyle option #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not take boolean. Should be one of the following: "markbegin" | "markbeginend" | "manual"
The foldStyle option under IAceOptions takes in boolean when it should take in on of the following: "markbegin" | "markbeginend" | "manual"; Please note that these options get passed directly to ace.editor.setOptions function, so all thats needed to fix an option is to change the option in the type.ts, type.d.ts and type.js files.
|
In fact, passing in |
securingsincity
approved these changes
Mar 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for
foldStyleoption inIAceOptionsNote: I checked to make sure there isnt some additional logic before this option is passed to
ace.editor.setOptionsthat would justify it taking abooleaninstead of whatsetOptionsaccepts forfoldStyle( one of the following:"markbegin" | "markbeginend" | "manual").Changes:
foldStyle? boolean->foldStyle? "markbegin"|"markbeginend"|"manual"in react-ace/types.d.tsfoldStyle? boolean;->foldStyle? "markbegin" | "markbeginend" | "manual";in react-ace/src/types.tsDocumentation:
References:
Ace Documentation on
foldStyleoption (Session options)Should resolve foldStyle type error #1790 (folding now works in my AceEditor components)