Rust graph #166
Merged
Rust graph #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #166 will degrade performances by 96.65%Comparing Summary
Benchmarks breakdown
|
seddonym
force-pushed
the
rust-graph
branch
9 times, most recently
from
aa72c92 to
25b711f
Compare
seddonym
force-pushed
the
rust-graph
branch
2 times, most recently
from
a5ca42f to
392b401
Compare
seddonym
commented
Feb 7, 2025
seddonym
commented
Feb 7, 2025
Peter554
reviewed
Feb 7, 2025
Merged
This is the main graph implemented in Rust - but it isn't plumbed into Python yet.
This adds a wrapper around the Rust-graph in lib.rs which handles the interface between Python and Rust. At the same time, it changes the Python ImportGraph so it uses Rust instead.
This is faster, but not cryptographically safe. That shouldn't matter for our purposes.
pytest-benchmark will actually determine a suitable number of rounds+iterations automatically (typically much more than 3!). With only 3 rounds the results are quite noisy.
Accessing graph.modules is more expensive than it looks.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the graph in Rust. 🥳
It took a while to get something that performs better - thanks @Peter554 for figuring out the final implementation.