Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not reset internal state of custom elements #364

Closed
akhilman opened this issue Feb 23, 2020 · 2 comments
Closed

Do not reset internal state of custom elements #364

akhilman opened this issue Feb 23, 2020 · 2 comments
Assignees
@akhilman
Labels
bug Something isn't working

Comments

@akhilman
Copy link
Member

akhilman commented Feb 23, 2020 •
edited
Loading

Right now seed is forcing re-initialization of custom elements to update code inside code-block on seed-rs.org (see #325 #328).

I propose to use a mutation observer to detect if the inner HTML of the custom element has changed (see example).

I'll take a care of this issue and updating code-block.
@MartinKavik MartinKavik added the bug Something isn't working label Mar 9, 2020
@akhilman akhilman mentioned this issue Apr 28, 2020
Closed
@akhilman
Copy link
Member Author

akhilman commented May 4, 2020 •
edited
Loading

Re-rendering on subtree change causes an infinity loop without a shadow DOM, and the code-block from seed-rs.org uses custom elements without a shadow DOM.

This was referenced May 4, 2020
Merged
Merged
MartinKavik pushed a commit that referenced this issue May 4, 2020
@akhilman @MartinKavik
Allow to patch custom elements
39a6480 
Solves #364
@akhilman
Copy link
Member Author

akhilman commented May 4, 2020

Done by #438 and seed-rs/seed-rs.org#46

@akhilman akhilman closed this as completed May 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@akhilman akhilman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhilman @MartinKavik