Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130
Resolves #131
Changes
subscribe
,subscribe_with_handle
,perform_cmd_with_handle
,stream
,stream_with_handle
andnotify
intoOrders
(perform_cmd and Cancellation #130).orders.rs
.subscribe
.routes
,window_events
,sink
andGMsg
(they are not deprecated yet).cmds::timeout
,stream::interval
,stream::window_event
,subs::UrlChanged
andsubs::UrlRequested
(Easy timeout/setInterval #131).subscribe
.todomvc
to use subscriptionUrlChanged
instead ofroutes
.perform_cmd
andperform_g_cmd
are executed immediately.send_msg(..)
andnotify(..)
is pushed into the queue to prevent recursion and stack overflow in theupdate
function.App
methodsnotify
andnotify_with_notification
.App
methodprocess_cmd_and_msg_queue
renamed toprocess_effect_queue
.routes
is not defined).UrlChanged
andUrlRequested
notifications and to behave consistently.cmds
,streams
,subs
,CmdHandle
,SubHandle
andStreamHandle
into the Seed's prelude.next_tick
.spawn_local
call, but it looks that it has been changed in the wasm_bindgen_futures -The future will always be run on the next microtask tick even if it immediately returns Poll::Ready.
And tests that should check it pass so it should be ok. I assume that users don't use it, but it was probably available from the public API, so it's breaking change.