Use correct case for XML (SVG) elements #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously XML elements which use some upper case letters would be converted to all-lowercase during string parsing. As xml is case-sensitive, this breaks the element. An example is the XML linearGradient. This was caused by the code incorrectly converting all element names to lowercase to ensure HTML tags are correctly assigned, as they use lower case internally, but the browser function tagName returns all caps for HTML tags. Fix this by only converting HTML element names to lower case. Fix: seed-rs#377
There were some spelling errors in the list of element names used to decide if the XML namespace should be assigned to the element. Note that this fix is not necessary for most modern browsers, as they already automatically provide the correct namespace for SVG etc.
klemens
force-pushed
the
fix-xml-element-parsing
branch
from
87ad4a8 to
1f8038a
Compare
|
Very nice! I just learned new stuff about Svg and Seed code 😄 |
This is a breaking change!
klemens
force-pushed
the
fix-xml-element-parsing
branch
from
1f8038a to
a418702
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously XML elements which use some upper case letters would be converted to all-lowercase during string parsing. As xml is case-sensitive, this breaks the element. An example is the XML linearGradient.
This was caused by the code incorrectly converting all element names to lowercase to ensure HTML tags are correctly assigned, as they use lower case internally, but the browser function tagName returns all caps for HTML tags.
The first two commits fix this, while the last one changes the names of the gradient macros to camel case (like the other svg macros). That last one is also a breaking change.