Fix parsing on saving through query #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogama
force-pushed
the
bugfix/parse-after-saving-through-query
branch
3 times, most recently
from
c6c7087
to
7604e8d
Compare
abelsoares
suggested changes
Nov 10, 2016
| model.get('foo').should.eql(['bar']); | ||
| }); | ||
|
|
||
| it('should keep a JSON value updating through query', async () => { |
There was a problem hiding this comment.
should keep a JSON value when updating through query
ricardogama
force-pushed
the
bugfix/parse-after-saving-through-query
branch
4 times, most recently
from
a5496fd
to
3bdc165
Compare
ricardogama
force-pushed
the
bugfix/parse-after-saving-through-query
branch
from
3bdc165
to
831a37d
Compare
abelsoares
approved these changes
Nov 11, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes parsing of columns when a
fetchedevent is triggered after inserting or updating through knex query builder.Closes #42