Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix object key order validation rule #5

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

nunofgs
Copy link
Contributor

@nunofgs nunofgs commented Nov 5, 2015

With asc, the INVALID_FIELD in the following example would need to be at the bottom:

Object keys must be in ascending order at ./src/constants.js :
   499 |  INVALID_EXTENSION: '21035',
   500 |  INVALID_FIELD: '30000',
   501 |  INVALID_FIELD_SELECTED: '21027',
----------^
   502 |  INVALID_FIELDS_SPECIFIED_IN_REQUEST: '10600',

R=@ruiquelhas

With `asc`, the `INVALID_FIELD` in the following example would need to be at the bottom:

```bash
Object keys must be in ascending order at ./src/constants.js :
   499 |  INVALID_EXTENSION: '21035',
   500 |  INVALID_FIELD: '30000',
   501 |  INVALID_FIELD_SELECTED: '21027',
----------^
   502 |  INVALID_FIELDS_SPECIFIED_IN_REQUEST: '10600',
```
@nunofgs nunofgs added the bug label Nov 5, 2015
@nunofgs nunofgs self-assigned this Nov 5, 2015
ruiquelhas added a commit that referenced this pull request Nov 5, 2015
…-keys-rule

Fix object key order validation rule
@ruiquelhas ruiquelhas merged commit fefaf7f into master Nov 5, 2015
@ruiquelhas ruiquelhas deleted the bugfix/fix-validate-order-in-object-keys-rule branch November 5, 2015 12:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants