Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix/issue 138 request validation #146

Merged

Conversation

dsmabulage
Copy link
Contributor

Purpose

The purpose of this PR is to fix #138

Goals

Add request validations via schema library to maintain consistent API parameters.

Approach

Add Zod lib to schema validation
validation is done in the middleware level

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@dileepainivossl
Copy link
Contributor

@anjula-sack comments resolved

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @dsmabulage

@anjula-sack anjula-sack merged commit 135dce9 into sef-global:main Aug 7, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request validation using zod
3 participants