Delete my profile implemented #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
requested changes
Aug 12, 2023
| if (!user || user.uuid !== userId) { | ||
| res.status(404).json({ message: 'Profile not found' }) | ||
| } else { | ||
| await deleteProfile(user) |
There was a problem hiding this comment.
Suggested change
| await deleteProfile(user) | |
| await deleteProfile(user.uuid) |
src/services/profile.service.ts
Outdated
| @@ -39,3 +39,14 @@ export const updateProfile = async ( | |||
|
|
|||
| return savedProfile | |||
| } | |||
|
|
|||
| export const deleteProfile = async (user: Profile): Promise<void> => { | |||
There was a problem hiding this comment.
Suggested change
| export const deleteProfile = async (user: Profile): Promise<void> => { | |
| export const deleteProfile = async (userId: string): Promise<void> => { |
anjula-sack
requested changes
Aug 12, 2023
| ): Promise<void> => { | ||
| try { | ||
| const userId = req.params.uuid | ||
| const user = await getProfile(req) |
There was a problem hiding this comment.
Suggested change
| const user = await getProfile(req) | |
| const user = req.user |
|
Hi @Danishkar, can you fix the conflicts? |
yea sure |
i will work on that |
Can you fix the lint errors as well? Run |
done |
anjula-sack
requested changes
Aug 17, 2023
|
@Danishkar the tests are failing |
yea bro I am new to this jest testing I will check on that. |
anjula-sack
requested changes
Aug 19, 2023
| res: Response | ||
| ): Promise<void> => { | ||
| try { | ||
| const userId = req.params.uuid |
There was a problem hiding this comment.
Suggested change
| const userId = req.params.uuid |
| try { | ||
| const userId = req.params.uuid | ||
| const user = req.user as Profile | ||
| if (!user || user.uuid !== userId) { |
There was a problem hiding this comment.
Suggested change
| if (!user || user.uuid !== userId) { | |
| if (!user) { |
src/routes/profile/profile.route.ts
Outdated
| @@ -9,5 +10,6 @@ const profileRouter = express.Router() | |||
|
|
|||
| profileRouter.get('/profile', requireAuth, getProfileHandler) | |||
| profileRouter.put('/profile', requireAuth, updateProfileHandler) | |||
| profileRouter.delete('/profile/:uuid', requireAuth, deleteProfileHandler) | |||
There was a problem hiding this comment.
Suggested change
| profileRouter.delete('/profile/:uuid', requireAuth, deleteProfileHandler) | |
| profileRouter.delete('/profile', requireAuth, deleteProfileHandler) |
anjula-sack
reviewed
Aug 22, 2023
anjula-sack
reviewed
Aug 22, 2023
anjula-sack
reviewed
Aug 22, 2023
|
@Danishkar can you take a pull and fix the lint issues @Danishkar |
anjula-sack
pushed a commit
to anjula-sack/scholarx-backend
that referenced
this pull request
Jul 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #11
Goals
Approach
Screenshots
Checklist
Related PRs
Test environment
Learning