Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve the entities and the HTTP status codes #56

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Improve the entities and the HTTP status codes #56

merged 4 commits into from
Aug 13, 2023

Conversation

anjula-sack
Copy link
Member

Purpose

The purpose of this PR is to improve the entities and the HTTP status codes

Goals

Improve the entities and the HTTP status codes

Approach

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@anjula-sack anjula-sack requested a review from Piumal1999 August 13, 2023 15:19
kumuditha-udayanga
kumuditha-udayanga approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@kumuditha-udayanga kumuditha-udayanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @anjula-sack!

@kumuditha-udayanga kumuditha-udayanga merged commit d8ad437 into sef-global:main Aug 13, 2023
anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
@Madhawa97
Implement user authentication (sef-global#56)
17f168a
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kumuditha-udayanga kumuditha-udayanga kumuditha-udayanga approved these changes

@Piumal1999 Piumal1999 Awaiting requested review from Piumal1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anjula-sack @kumuditha-udayanga