Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Retain session ID until timeout has elapsed between events #3

Merged
merged 3 commits into from
May 4, 2022

Conversation

MichaelGHSeg
Copy link
Contributor

Amplitude documentation indicated that the session ID should be retained until a period of time had elapsed between events, which was not matched by the existing implementation.

Copy link

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelGHSeg MichaelGHSeg merged commit d03edf1 into main May 4, 2022
@MichaelGHSeg MichaelGHSeg deleted the MichaelGHSeg/806-sessionid-retention branch May 4, 2022 17:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants