Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provider pattern for EventPipleline and new SyncEventPipeline for synchronous flush #101

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Provider pattern for EventPipleline and new SyncEventPipeline for synchronous flush #101

merged 4 commits into from
Apr 30, 2024

Conversation

MichaelGHSeg
Copy link
Contributor

No description provided.

@MichaelGHSeg MichaelGHSeg requested a review from wenxi-zeng April 29, 2024 16:25
wenxi-zeng
wenxi-zeng approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the idea of reusing the tests for different implementations of the same interface is super!

@MichaelGHSeg MichaelGHSeg merged commit 690f8b4 into main Apr 30, 2024
5 checks passed
@MichaelGHSeg MichaelGHSeg deleted the MichaelGHSeg/synchronous-flush branch April 30, 2024 16:39
@MichaelGHSeg
Copy link
Contributor Author

resolves #74

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wenxi-zeng wenxi-zeng wenxi-zeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelGHSeg @wenxi-zeng