-
Notifications
You must be signed in to change notification settings - Fork 271
[Ortto] - New Cloud Mode Destination #2912
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 78.11% 78.09% -0.03%
==========================================
Files 1050 1057 +7
Lines 19438 19572 +134
Branches 3735 3754 +19
==========================================
+ Hits 15184 15284 +100
- Misses 2972 3002 +30
- Partials 1282 1286 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @joe-ayoub-segment, just checking in on the PR — is there anything still needed from our side? Appreciate any updates when you get a chance. |
hi @xitonix nothing needed here. I'm planning to deploy this today, thought it's possible it might slip to tomorrow. |
Thanks, @joe-ayoub-segment — really appreciate it! Just a quick heads-up: we’d like to keep this limited to a few beta customers for now, rather than making it publicly available. |
PR deployed. Email to follow |
New Cloud Mode Destination Ortto
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.