Skip to content

[Ortto] - New Cloud Mode Destination #2912

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Conversation

joe-ayoub-segment
Copy link
Contributor

New Cloud Mode Destination Ortto

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Ortto (Actions), Settings:api_key
  • Destination: Ortto (Actions), Action:upsertContactProfile, Fields:user_id,anonymous_id
  • Destination: Ortto (Actions), Action:trackActivity, Fields:user_id,anonymous_id,event

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 74.62687% with 34 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (7d4dee8) to head (df9d5f9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ions/src/destinations/ortto/trackActivity/index.ts 36.84% 12 Missing ⚠️
...c/destinations/ortto/upsertContactProfile/index.ts 36.84% 12 Missing ⚠️
...ion-actions/src/destinations/ortto/ortto-client.ts 89.87% 5 Missing and 3 partials ⚠️
...estination-actions/src/destinations/ortto/index.ts 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   78.11%   78.09%   -0.03%     
==========================================
  Files        1050     1057       +7     
  Lines       19438    19572     +134     
  Branches     3735     3754      +19     
==========================================
+ Hits        15184    15284     +100     
- Misses       2972     3002      +30     
- Partials     1282     1286       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xitonix
Copy link

xitonix commented May 18, 2025

Hey @joe-ayoub-segment, just checking in on the PR — is there anything still needed from our side? Appreciate any updates when you get a chance.

@joe-ayoub-segment
Copy link
Contributor Author

hi @xitonix nothing needed here. I'm planning to deploy this today, thought it's possible it might slip to tomorrow.

@xitonix
Copy link

xitonix commented May 20, 2025

Thanks, @joe-ayoub-segment — really appreciate it! Just a quick heads-up: we’d like to keep this limited to a few beta customers for now, rather than making it publicly available.

@joe-ayoub-segment joe-ayoub-segment merged commit 43afbc1 into main May 20, 2025
10 of 13 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the ortto-new-destination branch May 20, 2025 15:25
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed. Email to follow

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants