fix ANR issue caused by MediaDRM api #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wenxi-zeng
commented
Feb 17, 2022
wenxi-zeng
commented
- fix ANR issue caused by MediaDRM api
prayansh
reviewed
Feb 17, 2022
| Device device = new Device(); | ||
| String identifier = collectDeviceID ? getDeviceId() : traits().anonymousId(); | ||
|
|
||
| // use empty string to indicate device id is not yet ready |
There was a problem hiding this comment.
lets add a comment that deviceId will be populated async
prayansh
approved these changes
Feb 17, 2022
| /** | ||
| * Workaround for not able to get device id on Android 10 or above using DRM API {@see | ||
| * https://stackoverflow.com/questions/58103580/android-10-imei-no-longer-available-on-api-29-looking-for-alternatives} | ||
| * {@see https://developer.android.com/training/articles/user-data-ids} | ||
| */ | ||
| private static String getUniqueID() { | ||
| public static String getUniqueID() { |
There was a problem hiding this comment.
given that this is not a safe API to use anymore, would it make sense to move it into the GetDeviceIdTask class?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.