Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

require version first as it is used in the defaults now #158

Merged
merged 1 commit into from
May 1, 2018

Conversation

nijikon
Copy link
Contributor

@nijikon nijikon commented May 1, 2018

balrog:web n$ be rspec
Bundler::GemRequireError: There was an error while trying to load the gem 'segment/analytics'.
Gem Load Error is: uninitialized constant Segment::Analytics::VERSION
Backtrace for gem load error is:
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics/defaults.rb:12:in `<module:Request>'
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics/defaults.rb:4:in `<module:Defaults>'
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics/defaults.rb:3:in `<class:Analytics>'
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics/defaults.rb:2:in `<module:Segment>'
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics/defaults.rb:1:in `<top (required)>'
/Users/n/dev/rb/repos/web/vendor/bundle/ruby/2.4.0/gems/analytics-ruby-2.2.4/lib/segment/analytics.rb:1:in `<top (required)>'

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          11       11           
  Lines         424      424           
=======================================
  Hits          418      418           
  Misses          6        6
Impacted Files Coverage Δ
lib/segment/analytics.rb 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c6a15...dbc6ae0. Read the comment docs.

@rohitpaulk rohitpaulk self-requested a review May 1, 2018 10:02
@rohitpaulk
Copy link
Collaborator

Thanks, @nijikon!

@rohitpaulk rohitpaulk merged commit 248698b into segmentio:master May 1, 2018
@nijikon nijikon deleted the require-version-first branch May 1, 2018 10:05
@nijikon
Copy link
Contributor Author

nijikon commented May 1, 2018

@rohitpaulk can you release?

@f2prateek
Copy link
Contributor

@nijikon thanks - i've pushed an update to version 2.2.5.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants