Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't assume that all errors are ConnectionErrors #187

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

rohitpaulk
Copy link
Collaborator

@rohitpaulk rohitpaulk commented Mar 30, 2019

Fixes an issue mentioned in #180.

The first part of the message ("Connection error") incorrectly led me to believe that the issue was in establishing a connection with Segment servers. This nudged my investigation towards HTTP-related issues and I eventually opened up a support ticket with Segment. We eventually realized the issue was a serialization error and were then able to correctly identify the problem and fix it. Had the error been labeled "Serialization error:" or something similar, finding the root of the bug would've taken much less time.

Copy link
Contributor

@f2prateek f2prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitpaulk rohitpaulk force-pushed the rohitpaulk/fix-error-logging branch from 2f8a1c6 to e55cd87 Compare April 2, 2019 15:09
@rohitpaulk rohitpaulk marked this pull request as ready for review April 2, 2019 15:09
@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          10       10           
  Lines         430      430           
=======================================
  Hits          423      423           
  Misses          7        7
Impacted Files Coverage Δ
lib/segment/analytics/request.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63549f7...e55cd87. Read the comment docs.

@rohitpaulk rohitpaulk merged commit 5d6a148 into master Apr 2, 2019
@rohitpaulk rohitpaulk deleted the rohitpaulk/fix-error-logging branch April 2, 2019 15:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants