Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enable-overriding-transport-options Pass options when initializing Transport #230

Merged

Conversation

annc128
Copy link
Contributor

@annc128 annc128 commented Apr 29, 2021

This change will allow users to override the default options so the library can be more flexible

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #230 (156f789) into master (5202c1d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          12       12           
  Lines         474      474           
=======================================
  Hits          470      470           
  Misses          4        4           
Impacted Files Coverage Δ
lib/segment/analytics/worker.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5202c1d...156f789. Read the comment docs.

@annc128
Copy link
Contributor Author

annc128 commented May 3, 2021

Hi @pooyaj, I was wondering if I can get your feedback on this PR? Thank you!

@pooyaj pooyaj requested a review from nd4p90x May 4, 2021 00:50
@pooyaj pooyaj merged commit 0eeafa0 into segmentio:master May 5, 2021
@annc128
Copy link
Contributor Author

annc128 commented May 5, 2021

@nd4p90x thanks for approving, I was wondering if the new version of gem will get published soon?

@nd4p90x
Copy link
Collaborator

nd4p90x commented May 5, 2021

@nd4p90x thanks for approving, I was wondering if the new version of gem will get published soon?

We are working on this now :)

@annc128
Copy link
Contributor Author

annc128 commented May 5, 2021

Awesome, thank you!

@pooyaj
Copy link
Contributor

pooyaj commented May 5, 2021

@annc128 New version ( 2.4.0 ) has been released!

@annc128
Copy link
Contributor Author

annc128 commented May 5, 2021

@pooyaj Much appreciated

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants