Telemetry module for Swift #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private var telemetryTimer: Timer? | ||
|
|
||
| func start() { | ||
| guard enable, !started, sampleRate != 0.0 else { return } |
There was a problem hiding this comment.
Maybe sampleRate > 0.0 && sampleRate <= 1.0 ?
Comment on lines
264
to
268
| var over = false | ||
| telemetryQueue.sync { | ||
| over = queue.count < maxQueueSize | ||
| } | ||
| return over |
There was a problem hiding this comment.
I think value determined is if you are "under" max queue size. Should that variable be changed to under ?
There was a problem hiding this comment.
That would make more sense. I like the guard clause but the inverted logic got me a bit.
didiergarcia
approved these changes
Oct 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.