Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support consumer groups in tail config #180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

isaacd9
Copy link

@isaacd9 isaacd9 commented Feb 24, 2024

Support consumer groups in tail.

Adds an argument to topicctl tail to support a consumer group --group-id. If set, this disables the partitions command is passed down to the reader.

I also updated repl with this.

I'm happy to write a test for this but would love some instruction on the preferred way to do so in this repo.

@isaacd9 isaacd9 requested a review from a team as a code owner February 24, 2024 17:14
@hhahn-tw
Copy link
Contributor

Hello - thanks for the contribution. While the command line form seems to work as expected, I'm having trouble with the repl form. When running eg. tail my-topic--group-id my-repl-group, it seems not to consume at all: it doesn't output any messages despite producing to it (via topicctl tester) and the group id is not reported by neither topicctl get groups nor kafka-consumer-groups.sh.

Without the --group-id flag, it works as expected (messages are output on the console as they are consumed).

Can you clarify what may be wrong?

Separately - can you update the help text for the repl form to include the --group-id flag?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants