Add workaround to generate type for events with no properties #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscb
suggested changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks for the hard work @harsh-joshi99 !
This looks good, I just left a suggestion.
The CI is failing due to the snapshots needing an update (they have some events with no events already so those will work now).
oscb
approved these changes
Jun 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a workaround to generate type for event with no properties by adding a non required dummy property.
JIRA -> STRATCONN-1998
Testing
Tested locally.