Skip to content

Replaced usage of assert keyword with "with" keyword to support node version 22.0.0 #705

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

aldenbe
Copy link
Contributor

@aldenbe aldenbe commented Apr 26, 2024

Fixes #704

@fgreinacher fgreinacher self-requested a review April 27, 2024 14:54
@fgreinacher
Copy link
Contributor

fgreinacher commented Apr 29, 2024

Looks we need to bump our minimum supported Node version to 20.10.0 nodejs/node#50682 because the with keyword support was only introduced in nodejs/node#50140.

--

Or maybe even simpler we could just use require like the GitHub plugin: https://github.com/semantic-release/github/blob/master/lib/definitions/errors.js#L7

@travi
Copy link
Member

travi commented Apr 29, 2024

I would be supportive of the breaking change within this plugin.

Looks like node v22 became "current" (will turn lts in six months) just a few days ago, which snuck up on at least me. Well likely see more folks running into this because of that update.

@travi
Copy link
Member

travi commented Apr 29, 2024

closing in favor of #708

thank you for bringing this to our attention!

@travi travi closed this Apr 29, 2024
@aldenbe
Copy link
Contributor Author

aldenbe commented Apr 30, 2024

I apologize, it was my belief that this feature was implemented in version 18.20.0 and therefore available in all subsequent versions, I did not fully understand that this 18 was an LTS version and that this feature would not necessarily be available in all versions of 20.x

@fgreinacher
Copy link
Contributor

No worries, that Node.js change was introduced in a quite subtle way... Thanks a ton for reaching out so quickly!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module causes failures in node version 22
3 participants