Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance gnssntripclient - Fixes #98 #100

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

  1. Enhance gnssntripclient exit and exception handling.

Fixes #98

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • x] My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added bug Something isn't working enhancement New feature or request labels Oct 30, 2024
@semuadmin semuadmin added this to the RC 1.1.5 milestone Oct 30, 2024
@semuadmin semuadmin self-assigned this Oct 30, 2024
@semuadmin semuadmin marked this pull request as draft October 30, 2024 10:09
@semuadmin semuadmin requested a review from a team October 30, 2024 10:10
@semuadmin semuadmin marked this pull request as ready for review October 30, 2024 10:41
@semuadmin semuadmin merged commit be49bbd into main Oct 30, 2024
@semuadmin semuadmin deleted the RELEASE-CANDIDATE-1.1.5 branch October 30, 2024 12:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTRIP socket persists after stop
2 participants