Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix structure of SEC-SIGLOG #157

Merged

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Sep 2, 2024

This PR fixes the SEC-SIGLOG message type by moving the reserved bytes into the repeated group as suggested by the interface description (Firmware version 1.40 and 1.50):
https://content.u-blox.com/sites/default/files/documents/u-blox-F9-HPG-1.50_InterfaceDescription_UBXDOC-963802114-12815.pdf

Testing

I tested this change on a receiver with version 1.50

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this Sep 2, 2024
@semuadmin semuadmin added the bug Something isn't working label Sep 2, 2024
@semuadmin semuadmin added this to the RC 1.2.45 milestone Sep 2, 2024
@semuadmin
Copy link
Contributor

@Niederb - Good spot, thanks - will go into v1.2.45 shortly.

@semuadmin semuadmin merged commit 93ebc13 into semuconsulting:master Sep 2, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants