Skip to content

fix: correct the LICENSE.md link in pom.xml #109

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2020
Merged

fix: correct the LICENSE.md link in pom.xml #109

merged 4 commits into from
Jul 17, 2020

Conversation

crweiner
Copy link
Contributor

Similar issue to PR #513 in your Java repo. If you have a template to deploy repos, be sure to fix the LICENSE linking errors upstream. 👍

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

The link to the LICENSE file in README.md points to LICENSE.txt when the actual MIT license file is LICENSE.md.

This PR fixes it to be the proper link. 👍

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 25, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@crweiner crweiner mentioned this pull request Oct 25, 2018
Merged
6 tasks
@crweiner crweiner changed the title Fix Link to LICENSE.md in README.md Fix Link to LICENSE.md in README.md and pom.xml Oct 26, 2018
@childish-sambino childish-sambino changed the title Fix Link to LICENSE.md in README.md and pom.xml fix: correct the LICENSE.md link in pom.xml Jul 17, 2020
@childish-sambino childish-sambino merged commit 9124e09 into sendgrid:master Jul 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crweiner @SendGridDX @childish-sambino @thinkingserious