added charset functionality #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @daarond - thank you for this, but please re-submit without the PhpStorm files and more importantly with a commit change that doesn't show an entire deletion and then re-addition of of the Mail.php and Smtp.php. It's not ideal to have a diff that shows the entire file changing - when really it was only the addition of the charset portions. Please submit as a separate pull request. I'm closing this one. Probably the best thing is to delete your fork, and then re-fork from current master. Then re-add the charset changes you added. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra files are from PhpStorm, feel free to delete them.