Skip to content

fix: Ignore submodules in test directory #1071

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davismr
Copy link

@davismr davismr commented Aug 22, 2023

so they are not installed under test folder in python site-packages

Also remove the temp*.py exclusion as this does not seem to have any purpose

Fixes

Installing sendgrid will also install test folder, with two sub folders in site-packages. This can create conflicts at worst and creates noise at best. Currently test folder is ignore in find_packages, but tests have been split into sub-modules and the find_packages exclude attribute was not updasted.

To test, install current main branch. Confirm test folder is in site-packages. Uninstall sendgrid, delete test folder in site-packages, delete *.egg-info folder, delete build folder, reinstall. test folder is no longer installed

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@davismr davismr changed the title FIX: Ignore submodules in test directory fix: Ignore submodules in test directory Aug 22, 2023
@davismr davismr closed this Aug 22, 2023
@davismr davismr reopened this Aug 22, 2023
so they are not installed under test folder in python site-packages

Also remove the temp*.py exclusion as this does not seem to have any purpose
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant