Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update CONTRIBUTING.md #262

Merged
merged 1 commit into from
Oct 22, 2018
Merged

update CONTRIBUTING.md #262

merged 1 commit into from
Oct 22, 2018

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Oct 31, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • makes Environmental Variables a sub topic

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thepriefy
update CONTRIBUTING.md
b832154 
makes Environmental Variables a sub topic
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 2e0f3e5 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thepriefy @thinkingserious @clee @mbernier