Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update readme tags and fix minor test failures #303

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Update readme tags and fix minor test failures #303

merged 3 commits into from
Oct 23, 2018

Conversation

af4ro
Copy link
Contributor

@af4ro af4ro commented Aug 7, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added tag for open source contributors to readme
  • Fix minor test failures

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 7, 2018
@SendGridDX
Copy link

SendGridDX commented Aug 7, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@af4ro af4ro changed the title Update readme tags Update readme tags and fix minor test failures Aug 7, 2018
@jpurpura jpurpura added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy labels Aug 13, 2018
@thinkingserious thinkingserious removed the status: code review request requesting a community code review or review from Twilio label Oct 23, 2018
@thinkingserious thinkingserious merged commit c7592c5 into master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @af4ro,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the af4ro-patch-1 branch January 17, 2020 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@af4ro @SendGridDX @thinkingserious @jpurpura