Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: move dev-only dependencies to devDependencies #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sodabrew
Copy link

@sodabrew sodabrew commented Aug 5, 2023

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

Accepted.

Fixes

This package does not have a runtime dependency on chai or esdocs. These are devDependencies. The two negative effects of having these listed as runtime dependencies are larger bundle / node_modules size at runtime and that downstream applications get flagged by Dependabot and other tools for having vulnerable and outdated dependencies.

See PR #53 for the original addition of these deps.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant