(refactor) O3-3012: Switch registering appointments form workspace ba… (

openmrs#1068)
senthil-athiban · Apr 15, 2024 · 47e0fad · 47e0fad
1 parent 12d4454
commit 47e0fad
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/packages/esm-appointments-app/src/index.ts b/packages/esm-appointments-app/src/index.ts
@@ -4,14 +4,10 @@ import {
   getAsyncLifecycle,
   getSyncLifecycle,
   registerBreadcrumbs,
-  translateFrom,
 } from '@openmrs/esm-framework';
 import { configSchema } from './config-schema';
 import { createDashboardLink } from './createDashboardLink.component';
-import {
-  createDashboardLink as createPatientChartDashboardLink,
-  registerWorkspace,
-} from '@openmrs/esm-patient-common-lib';
+import { createDashboardLink as createPatientChartDashboardLink } from '@openmrs/esm-patient-common-lib';
 import { dashboardMeta, appointmentCalendarDashboardMeta, patientChartDashboardMeta } from './dashboard.meta';
 import {
   cancelledAppointmentsPanelConfigSchema,
@@ -104,8 +100,4 @@ export const patientAppointmentsCancelConfirmationDialog = getAsyncLifecycle(
   options,
 );
 
-registerWorkspace({
-  name: 'appointments-form-workspace',
-  load: getAsyncLifecycle(() => import('./form/appointments-form.component'), options),
-  title: translateFrom(moduleName, 'createNewAppointment', 'Create new appointment'),
-});
+export const appointmentsFormWorkspace = getAsyncLifecycle(() => import('./form/appointments-form.component'), options);
diff --git a/packages/esm-appointments-app/src/routes.json b/packages/esm-appointments-app/src/routes.json
@@ -69,6 +69,16 @@
       "name": "early-appointments-panel",
       "component": "earlyAppointments"
     },
+    {
+      "name": "appointments-form-workspace",
+      "component": "appointmentsFormWorkspace",
+      "meta": {
+        "title": {
+          "key": "createNewAppointment",
+          "default": "Create new appointment"
+        }
+      }
+    },
     {
       "name": "patient-appointments-summary-dashboard",
       "component": "patientAppointmentsSummaryDashboardLink",

diff --git a/packages/esm-appointments-app/src/types/index.ts b/packages/esm-appointments-app/src/types/index.ts
@@ -13,6 +13,7 @@ export interface AppointmentLocation {
   name: string;
 }
 
+// TODO: remove interface elements that aren't actually present on the Appointment object returned from the Appointment API
 export interface Appointment {
   appointmentKind: string;
   appointmentNumber: string;