-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
added space function to art and aprint #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts. There are some points you should take into consideration before checking my comments:
- There is no rush. most of my comments were mentioned by @sepandhaghighi in your last PR but were not taken into action.
- You should update
CHANGELOG.md
, too. - You should write tests for your new features.
- You can commit on your branch and this PR will be updated. So no need for closing PR after each review and opening new one.
sorry about the confusion ill send a new pr, can you tell me where should i write the tests , I am confused |
No need for new PR @codewithnick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for changes. I left a minor comment.
Codecov Report
@@ Coverage Diff @@
## dev #248 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 7 7
Lines 1185 1185
Branches 79 79
=======================================
Hits 1183 1183
Misses 1 1
Partials 1 1
|
I will add tests myself after your last commit. @codewithnick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codewithnick Well done 🔥
I comment on some minor issues.
Please address them, after that we will merge this PR 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since I do not have push access to @codewithnick 's fork, I'll open a PR fixing tests afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
thank you so much guys let me know if can also work on something else |
Reference Issues/PRs
#241
What does this implement/fix? Explain your changes.
added space parameter in art and aprint functions
Any other comments?