Bugfix: ValueError when using Decimal 0.x #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epou
commented
Aug 17, 2022
•
epou
commented
- Solved bug when using Decimal 0.x numbers
- Compatibility with complex numbers
- Added tests
- Fixes ValueError: valid range for prec is [1, MAX_PREC] #338
epou
force-pushed
the
bugfix_valueerror_decimal_zero
branch
4 times, most recently
from
d674ef0 to
cfab1ea
Compare
seperman
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Hi @epou
Thanks for the PR! It looks great. Do you mind adding a test case that covers the changes for complex numbers? We already have 2 tests for complex numbers but I'm not sure why more code was needed to handle complex numbers.
|
I'm gonna be cutting a new release so gonna merge this. |
|
Let me add some more tests before. I'll do it today |
epou
force-pushed
the
bugfix_valueerror_decimal_zero
branch
from
cfab1ea to
4a1e5b3
Compare
|
I've updated the PR. Let me know your opinion :D |
|
@epou |
|
@epou DeepDiff 6.1.0 is published. It includes your PR. Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.